search

EvotecIT / ADEssentials

PowerShell Active Directory helper functions to manage healthy Active Directory
442 stars 54 forks source link

Typos & french language support #5

Closed SUBnet192 closed 4 years ago

PrzemyslawKlys commented 4 years ago

Since you're renaming function please add alias with old name. I know it's wrong, but still we need to at least support old version. I have Supress in PSWriteWord that needs to be Suppress for like 50 commands but I need to add aliases as well.

SUBnet192 commented 4 years ago

ouch. I would simply implement a required version for dependencies instead of doing that...

PrzemyslawKlys commented 4 years ago

I can fix my stuff. But do you know who is using PSWriteWord or ADEssentials or other commands? Looking at PSGallery there are loads of people using it.

SUBnet192 commented 4 years ago

I understand. For your own dependencies it's fixable. Anyone who updates will get the new corrected names and would have to fix their own scripts for it. I think that's fair. As long as there's a heads-up somewhere in a readme file or something. Your call :) I know I wouldn't, otherwise I'd be dragging these aliases forever.

SUBnet192 commented 4 years ago

Where do you want me to define these aliases?

PrzemyslawKlys commented 4 years ago

As with most of my commands:

Function New-HTML {
    [alias('Dashboard')]
    [CmdletBinding()]
    param(

It shouldn't be a problem to have aliases like that. It's added once and I'll remove it at some point. You could always update readme as well :)

SUBnet192 commented 4 years ago

Like this?

Function Get-WinADPrivilegedObjects { [alias('Get-WinADPriviligedObjects')] [cmdletbinding()] param(

PrzemyslawKlys commented 4 years ago

Yep ;)