search

EvotecIT / OfficeIMO

Fast and easy to use cross-platform .NET library that creates or modifies Microsoft Word (DocX) and later also Excel (XLSX) files without installing any software. Library is based on Open XML SDK
MIT License
289 stars 50 forks source link

Added WordParagraphStyles.Custom #237

Closed ChrisBellBO closed 3 months ago

ChrisBellBO commented 4 months ago

Added WordParagraphStyles.Custom

PrzemyslawKlys commented 4 months ago

Would you be able to add some tests for this?

ChrisBellBO commented 3 months ago

Added a test and fixed the tests that my original change broke. I've also updated the reference to SixLabors.ImageSharp due to a vulnerability

PrzemyslawKlys commented 3 months ago

you should maintain the old way it was written in config, it prevents updating to 3.0.0, which is not compatible :)

ChrisBellBO commented 3 months ago

I'm not sure I understand, I upgraded to 2.1.9 which doesn't have the vulnerability?

PrzemyslawKlys commented 3 months ago

image

The brackets that are used, prevent users from getting ImageSharp 3.0+ and claiming OfficeIMO doesn't work. Same for OpenXML. You should just set 2.1.9 as minimum, and maximum 2.X.X excluding 3.0.0 which is what the brackets do

ChrisBellBO commented 3 months ago

Got it, thanks. Fixed that