EvotecIT / PSWinReporting

This PowerShell Module has multiple functionalities, but one of the signature features of this module is the ability to parse Security logs on Domain Controllers providing easy to use access to AD Events.
MIT License
705 stars 70 forks source link

ErrorAction Stop stopping on non-critical errors #23

Closed PrzemyslawKlys closed 5 years ago

PrzemyslawKlys commented 5 years ago

@snd3r

image

Your setting did this. I guess one must go now thru every possible scenario and fix Try/Catch errors with this one. Get-WinEvent is very weird in that if there's no events found it will throw error (I would expect it to not do that). Please add some logic to it then.

PrzemyslawKlys commented 5 years ago

@snd3r will you fix this? Or should I?

snd3r commented 5 years ago

Sorry for the silence. I work on the script and check all the errors and the correctness of their catching and processing.

PrzemyslawKlys commented 5 years ago

@snd3r How is it going?

snd3r commented 5 years ago

Is the problem relevant?

PrzemyslawKlys commented 5 years ago

Not anymore I think. Works as required.