search

EvotecIT / Testimo

Testimo is a PowerShell module for running health checks for Active Directory against a bunch of different tests
MIT License
526 stars 58 forks source link

DNSResolveExternal test reports failures on A records returned in the Authority and Additional sections #132

Closed rmbolger closed 3 years ago

rmbolger commented 3 years ago

This issue is very similar to https://github.com/EvotecIT/ADEssentials/issues/17

The code that checks resolution against testimo-check.evotec.xyz fails to limit the results to A records in the Answer section. So there are a bunch of false failures in the test output for the NS records in the Authority section and the A records associated with those NS records in the Additional section.

https://github.com/EvotecIT/Testimo/blob/738b23f4aeefaae151857e003cf8b41f1e05e8e1/Private/SourcesDomainControllers/DNSResolveExternal.ps1#L7-L9

The code should be updated to only consider the A record values returned in the Answer section.

PrzemyslawKlys commented 3 years ago

Thank you for your PR. Really apppreciate it