EvotecIT / Testimo

Testimo is a PowerShell module for running health checks for Active Directory against a bunch of different tests
MIT License
526 stars 58 forks source link

Group Policy SysvolDC checking for non-existent property #135

Closed jwmoss closed 3 years ago

jwmoss commented 3 years ago

While running this for the first time, I discovered an issue which may stem from Get-GPOZaurrSysvol.

In line 7 of GroupPolicySysVolDC, you're checking for SysvolStatus property:

Get-GPOZaurrSysvol -IncludeDomains $Domain -IncludeDomainControllers $DomainController -VerifyDomainControllers | Where-Object { $_.SysvolStatus -ne 'Exists' -or $_.Status -ne 'Exists' }

But the property doesn't exist.

image

Which returns a false negative

image

PrzemyslawKlys commented 3 years ago

Ye, it seems I've rewritten Get-GPOZaurrSysVol in GPOZaurr without updating Testimo. Thanks for noticing.

jwmoss commented 3 years ago

Ye, it seems I've rewritten Get-GPOZaurrSysVol in GPOZaurr without updating Testimo. Thanks for noticing.

Sure thing!