search

EwyBoy / OreTweaker

Add, remove, tweak and configure ore and underground generation features for Minecraft Forge
https://www.curseforge.com/minecraft/mc-mods/ore-tweaker
MIT License
20 stars 7 forks source link

Conflict with zycraft's zychorium ore-gen #11

Closed frank89722 closed 3 years ago

frank89722 commented 3 years ago

Forge version: 36.1.16 OreTweaker version: 2.0.1 ZYcraft: https://github.com/nikita488/ZYCraft

All configs are default

Before OreTweaker installed: image

After: image

EwyBoy commented 3 years ago

Thanks, will look into it.

frank89722 commented 3 years ago

It seems like only happened when replacing "minecraft:lapis_ore" in the json file, but this is only valid in only vanilla ores in the config.

I have tried to remove lapis ore in the setting for my large modpack with other moded ores in it, but it still not work.

Hope this information is helpful to you!

EwyBoy commented 3 years ago

Yes, had the same bug for Create. Still struggling how to fix it, but I can hard code a temporary workaround

frank89722 commented 3 years ago

Maybe could move the adding event to high priority, and split the removing part to a low priority event? 🤔

Also, quark seems like having the same issue. If you decide to code a temporary workaround, it would be nice to having quark support.

All the best!

EwyBoy commented 3 years ago

2021-05-13_08 58 55 I fixed it, found the issue.

https://github.com/EwyBoy/OreTweaker/blob/ec5e21029fcaa5fe9ca2a860d0be719f5c117c0d/src/main/java/com/ewyboy/oretweaker/tweaking/construction/OreDeconstruction.java#L45

There is a loop grabbing the ore from the ore gen feature, and I check if the block != null. If yes I remove that feature. But the block is never set back to null at the start / end of the loop and will therefore remove all the next entries. I lost sleep over this simple little issue and took me days to debug..

I moved the Block targetBlock = null; inside the loop and now everything works fine.

EwyBoy commented 3 years ago

I consider this issue now fixed. Thank you for your bug report. Patch can be found here: https://www.curseforge.com/minecraft/mc-mods/ore-tweaker/files/3307868