EwyBoy / OreTweaker

Add, remove, tweak and configure ore and underground generation features for Minecraft Forge
https://www.curseforge.com/minecraft/mc-mods/ore-tweaker
MIT License
20 stars 7 forks source link

[Bug] Setting value for minY to -1 stops ore from spawning, even when maxY is not -1 #79

Open Goldenlion5648 opened 2 years ago

Goldenlion5648 commented 2 years ago
Minecraft Version

1.18.2

Forge Version

40.1.30

Mod Version

OreTweaker-1.18.2-3.3.0.jar

Describe the bug

Setting minY to -1 makes ore not spawn (even when maxY is greater than -1). I think the ore should only be disabled when both values are -1.

How to reproduce

set minY to -1, and maxY to a value such as 9 for an ore. Ore does not spawn as a result

Screenshots / Images

The ore in this case is lava replacing grass blocks minY at -1 minY at -1

minY at 0 minY at 0

EwyBoy commented 2 years ago

You are right, there has probably been an oversight in the code when porting to 1.17 when the worlds expanded to go below 0. I think the old value for disabling ores where to set the values to -1.

Thank you for the detailed bug report.