search

EwyBoy / SeedDrop

Minecraft mod that lets you configure what drops from breaking grass with JSON or Commands.
https://www.curseforge.com/minecraft/mc-mods/seed-drop
MIT License
5 stars 2 forks source link

Fixes load order, adds meta support #1

Closed codetaylor closed 6 years ago

codetaylor commented 6 years ago

Load Order

Items initialized by mods that had a preInit phase after this mod weren't being recognized by this mod when it tried to add the drops. I moved the call to registerSeeds() to the init phase. This ensures that all mods have a chance to initialize their items / blocks in the preInit phase before this mod tries to add them as seed drops.

Meta Support

I needed meta support for items such as survivalist:rock:1. The registerSeeds() method now parses for meta and supplies some error logging if the user makes a typo while configuring.

Notes

I made these changes mainly for myself and my private modpack, but you are more than welcome to merge them in. :)

EwyBoy commented 6 years ago

Thank you so much for this. This mods has not been prioritized lately and an overhaul very much needed. I will implement the changed and port it to every version form 1.7-1.12. Thanks a lot for your PR.

-Ewy

EwyBoy commented 6 years ago

Builds from 1.8-1.12 is live now with the changes. Also added some extra info too the config explaining the weigh system forge uses. https://minecraft.curseforge.com/projects/seed-drop Credited you in the change log. -Ewy