[Bug 1.18.1] Dropping 6-8 seeds at once

itsdinkd commented 2 years ago

it never drops just one seed. it will drop a bundle of seeds.

here is my config


{
  "dropConfig": [
    {
      "item": "minecraft:wheat_seeds",
      "chance": 35.0
    },
    {
      "item": "minecraft:pumpkin_seeds",
      "chance": 27.0
    },
    {
      "item": "minecraft:melon_seeds",
      "chance": 22.0
    },
    {
      "item": "minecraft:beetroot_seeds",
      "chance": 27.0
    },
    {
      "item": "veggie_way:quinoa_seeds",
      "chance": 20.0
    },
    {
      "item": "veggie_way:soybean_seeds",
      "chance": 20.0
    },
    {
      "item": "veggie_way:lentil_seeds",
      "chance": 20.0
    },
    {
      "item": "veggie_way:corn_seeds",
      "chance": 20.0
    },
    {
      "item": "immersiveengineering:seed",
      "chance": 15.0
    },
    {
      "item": "silentgear:flax_seeds",
      "chance": 10.0
    },
    {
      "item": "silentgear:fluffy_seeds",
      "chance": 20.0
    },
    {
      "item": "croptopia:artichoke_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:asparagus_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:bellpepper_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:blackbean_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:blackberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:blueberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:broccoli_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:cabbage_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:cantaloupe_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:cauliflower_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:celery_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:coffee_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:corn_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:cranberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:cucumber_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:currant_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:eggplant_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:elderberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:garlic_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:grape_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:greenbean_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:greenonion_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:honeydew_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:hops_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:kale_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:kiwi_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:leek_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:lettuce_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:olive_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:onion_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:peanut_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:pineapple_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:radish_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:raspberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:rhubarb_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:rice_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:rutabaga_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:saguaro_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:spinach_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:squash_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:strawberry_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:sweetpotato_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:tomatillo_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:tomato_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:turnip_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:yam_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:zucchini_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:mustard_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:chile_pepper_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:turmeric_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:ginger_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:basil_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:oat_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:barley_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:soybean_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:vanilla_seeds",
      "chance": 20.0
    },
    {
      "item": "croptopia:pepper_seed",
      "chance": 20.0
    },
    {
      "item": "croptopia:tea_seed",
      "chance": 20.0
    },
    {
      "item": "occultism:datura_seeds",
      "chance": 15.0
    }
  ]
}```

EwyBoy commented 2 years ago

This is not a bug. Up on breaking the grass, each seed is rolled for at the percent chance you have set for it. In your case there is a 20% chance for every single seed in that list to drop.

Lower ur drop percentage for every drop. A nice math formula to determine a balanced drop rate is the percent chance you want to grass to drop a seed and dive it by the number of seed you have added to the config. Then use this number for each seed in the list.

Wanted chance to revive a drop / number of seeds in list

Example can be set to a low value like:

 {
      "item": "occultism:datura_seeds",
      "chance": 0.025
  }

So if you want to have a 20% chance to on average receive a drop and lets say you have 40 seeds in your list. 20 / 40 = 0.5 now set the chance for 0.5 for every drop in ur list.

itsdinkd commented 2 years ago

Ah okay. I was originally going to do that formula but then I saw on your examples you went past 100% on total combined chance so I figured it did something different. Makes sense now though, thanks

On Mon, Jan 17, 2022, 11:03 AM Eivind Norling @.***> wrote:

Closed #11 https://github.com/EwyBoy/SeedDrop/issues/11.

— Reply to this email directly, view it on GitHub https://github.com/EwyBoy/SeedDrop/issues/11#event-5906342620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIL5CKEPSGXGIYEN3IFW43DUWRRZBANCNFSM5MFKEHFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

EwyBoy / SeedDrop

[Bug 1.18.1] Dropping 6-8 seeds at once #11