search

EwyBoy / World-Stripper

Strips away blocks to reveal the underground world gen. A must have tool for all map-makers, pack-makers or developers.
https://www.curseforge.com/minecraft/mc-mods/world-stripper
MIT License
13 stars 3 forks source link

Customized profile lists are ignored #6

Closed tyra314 closed 6 years ago

tyra314 commented 6 years ago

BlocksToStrip.blockList doesn't seem right: https://github.com/EwyBoy/World-Stripper/blob/master/src/main/java/com/ewyboy/worldstripper/common/network/PacketStripWorld.java#L51

Should be something around this: Config.stripProfile[Config.profile]

EwyBoy commented 6 years ago

This is some old source code from a failed github merge. This is the class that works https://github.com/EwyBoy/World-Stripper/blob/master/src/main/java/com/ewyboy/worldstripper/common/network/packets/PacketStripWorld.java

tyra314 commented 6 years ago

Okay, then I have to rephrase the issue...

Forge Version & World-Stripper

MC: 1.12.2 Forge: 14.23.1.2561 WS: 1.5.0-1.12.2

Expected behavior

Blocks added to the profile lists should be stripped

Actual Behavior

They don't.

Link to Crashlog or Forgelog [If Applicable]
Steps to reproduce [If Applicable]

Add an additional block to the used profile, which isn't part of the default. For example minecraft:gold_block. Place this block in the world at your feets. Strip world. Block still there.

EwyBoy commented 6 years ago

okey, I can that was a bit easier to understand. I will look into it.

EwyBoy commented 6 years ago

Found the issue. It was a tiny typo from copy / pasting: https://github.com/EwyBoy/World-Stripper/blob/cb023cccd8cb4d086c40ea012d656a7eb9727b84/src/main/java/com/ewyboy/worldstripper/common/util/Config.java#L76

Pushing 5 builds for version 1.8 to 1.12 now. Should be named 1.5.1 and be up on CurseForge soon.

Thanks for the report and info! -Ewy