search

Ex-Mente / auxi.0

GNU Lesser General Public License v3.0
8 stars 8 forks source link

Issue 87 #139

Closed mwerwee closed 7 years ago

mwerwee commented 8 years ago

Fixed standard Urbain model and made sure Riboud model is correct. The dataset needs to be re-evaluated. Added the Modified Urbain model.

Need to add reference for modified urbain model to bibtex file

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 76.025% when pulling 9afd6dc848615c713a08e70a13c3184ca09aabd6 on mwerwee:issue-87 into 90559c8dfa9203a11032e9df08504a7488e1537d on Ex-Mente:develop.

christoffkok commented 8 years ago

Hi Markus,

The quality of your code is really good!

I am waiting for Johan to review your changes as my metallurgy knowledge is terrible to non-existent. He won't be able to do it today. We will add it to next week's release.

I've made some comments on the changes you made. Thank you for the good quality code.

Regards, Christoff

johanzietsman-em commented 8 years ago

Hi Markus

Thanks for the contribution. It looks great. I added a note above about references and data sets. Please address this. I also responded to your question on the forum about how to add your own references and data sets.

Your issue number is actually 86, and not 87. I am not sure where this misunderstanding originated. Please rename your local branch to issue-86, and address the issues that @christoffkok and I highlighted. Then push to branch issue-86 on your fork (referred to as origin). From there you can do a pull request from your branch issue-86 to the central repository (upstream) branch issue-86. Things should run smoothly from there.

Thanks

Johan

mwerwee commented 7 years ago

Deleting branch / closing pull request. Will change everything properly on the actual issue (Issue #86)