search

Ex-Mente / auxi.0

GNU Lesser General Public License v3.0
8 stars 8 forks source link

Verify and validate slag viscosity models #86

Open johanzietsman-em opened 8 years ago

johanzietsman-em commented 8 years ago

Background

We have implemented two slag viscosity models in tools/materialphysicalproperties/slags.py. Based on preliminary tests it seems that these models have some problems. We need to do more work to ensure that these models can be used with confidence.

Purpose

The purpose of this issue is to get the Urbain and Riboud slag viscosity models to a point where they can be formally released, and used with confidence by the community.

mwerwee commented 8 years ago

Indeed some problems. Some of the constants in the Urbain model is incorrect. Have identified them and will commit changes soon. This will also include the modified Urbain model.

Sourcing the original Riboud reference, since there seems to be something missing (the x1 variable is not used in the equations).

mwerwee commented 7 years ago

Fixed Urbain and Riboud models. Added Modified Urbain model. I would close this issue and push it if possible, such that there two can be used in the interim (Still waiting for the Riboud reference, albeit it has been quoted several times without the x1 parameter). I reckon those that know the models (and where they are applicable can start using them now, whilst we refine code?). Will open a new issue for improvement once we've done some extra coding.