search

Ex1sten / epgp

Automatically exported from code.google.com/p/epgp
0 stars 0 forks source link

"show offline members" is locked and greyed out #635

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1.Just have EPGP on.
2.
3.

What is the expected output? What do you see instead?
It shouldn't be locking me out from un-checking "show offline members".

What version of the product are you using? What locale is your client (en,
ru, kr, ch, es, tw)? What other addons do you have installed and what
versions? How many members do you have in your guild? (/guildinfo).
Version 5.5.22 (EN-US) 76 playersin guild.

Paste the text surrounded by -EPGP- in Guild Information here:

If this is about http://www.epgpweb.com integration, what is the realm
and region of your guild?

Please provide any additional information below.
If I disable EPGP, it goes back to normal.  But if I were to raid tonight, and 
have to give out points, I will have to be stuck w/ "show offline members" 
locked on "on".

Original issue reported on code.google.com by matthews...@gmail.com on 15 Oct 2010 at 12:32

GoogleCodeExporter commented 8 years ago 
This is the only way for EPGP to work properly atm.

Original comment by evlogimenos on 15 Oct 2010 at 9:04

GoogleCodeExporter commented 8 years ago 
Bump for resolution... I'm hoping the "atm" means this will be looked into...

Original comment by Hobb...@gmail.com on 16 Oct 2010 at 2:56

GoogleCodeExporter commented 8 years ago 
God I hope so.  Cuz it's really really annoying to find guildies online

Original comment by matthews...@gmail.com on 16 Oct 2010 at 2:58

GoogleCodeExporter commented 8 years ago 
I am sure it being looking into. Easy solution to see who is online is sort the 
guild roster list by Guild Status, Last Online.

Original comment by dingochavezz@gmail.com on 16 Oct 2010 at 3:07

GoogleCodeExporter commented 8 years ago 
Very annoying problem, I really hope there can be a fix or workaround for this 
soon. Obviously we officers can't do without EPGP, so it would be really nice 
to get our normal guild list back.

Original comment by liann...@gmail.com on 17 Oct 2010 at 6:11

GoogleCodeExporter commented 8 years ago 
Issue 637 has been merged into this issue.

Original comment by evlogimenos on 17 Oct 2010 at 10:00

GoogleCodeExporter commented 8 years ago 
Issue 638 has been merged into this issue.

Original comment by evlogimenos on 17 Oct 2010 at 10:01

GoogleCodeExporter commented 8 years ago 
Issue 639 has been merged into this issue.

Original comment by evlogimenos on 17 Oct 2010 at 10:02

GoogleCodeExporter commented 8 years ago 
Why is this marked will not fix?  It's a easily reproducible bug.

Original comment by bdelli...@gmail.com on 17 Oct 2010 at 11:41

GoogleCodeExporter commented 8 years ago 
Issue 643 has been merged into this issue.

Original comment by evlogimenos on 18 Oct 2010 at 9:55

GoogleCodeExporter commented 8 years ago 
Issue 644 has been merged into this issue.

Original comment by evlogimenos on 19 Oct 2010 at 6:20

GoogleCodeExporter commented 8 years ago 
bdelliott: Read comment #1.

Original comment by evlogimenos on 19 Oct 2010 at 6:34

GoogleCodeExporter commented 8 years ago 
Sorry I did read it, didn't understand it.  Did you mean it cannot be fixed and 
I should simply disable the addon when not raiding?

Original comment by bdelli...@gmail.com on 19 Oct 2010 at 1:00

GoogleCodeExporter commented 8 years ago 
There won't be a solution until epgp 6.0.

Original comment by evlogimenos on 19 Oct 2010 at 1:17

GoogleCodeExporter commented 8 years ago 
Okay, thank you.

Original comment by bdelli...@gmail.com on 19 Oct 2010 at 1:21

GoogleCodeExporter commented 8 years ago 
Issue 645 has been merged into this issue.

Original comment by evlogimenos on 20 Oct 2010 at 5:54

GoogleCodeExporter commented 8 years ago

Original comment by evlogimenos on 20 Oct 2010 at 5:56

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I've made a work around for it.

Open the LibGuildStorage-1.0.lua file and add SHOWOFFLINE = true;  to the top.

also in LibGuildStorage-1.0.lua, replace

ForceShowOffline() (line 245)  

With

if SHOWOFFLINE then
   ForceShowOffline()
end

Open the epgp.lua file and find 

function EPGP:OnInitialize()

Beneath it add the following...

    --store original function
    local original_ToggleGuildFrame = ToggleGuildFrame;
    --asign new function
    ToggleGuildFrame = function(...)
    --new function

    --Object has not yet been created, so just set need to disable showing offline
        SHOWOFFLINE = false;
        SetGuildRosterShowOffline(false)

        --Open the guild frame
        original_ToggleGuildFrame()

        --Guild frame hide handler
        GuildFrame:SetScript("OnHide",function() 
            PlaySoundFile("Sound\\interface\\uCharacterSheetClose.wav")
            SHOWOFFLINE = true 
        end )

        --Guild frame show handler
        GuildFrame:SetScript("OnShow",function() 

            SHOWOFFLINE = false;
            SetGuildRosterShowOffline(false)
            if GuildRosterShowOfflineButton then
                GuildRosterShowOfflineButton:SetChecked(false)
                GuildRosterShowOfflineButton:Enable()
            end
            PlaySoundFile("Sound\\interface\\uCharacterSheetOpen.wav")
        end )

        --restore ToggleGuildFrame function
        ToggleGuildFrame = original_ToggleGuildFrame
    end

Original comment by mbuca...@gmail.com on 21 Oct 2010 at 5:08

Attachments:

GoogleCodeExporter commented 8 years ago 
What does this fix exactly? Don't start downloading this until you are clear 
about what it does.

Original comment by dingochavezz@gmail.com on 21 Oct 2010 at 10:39

GoogleCodeExporter commented 8 years ago 
=to dingoshavezz=
Unrespectable replay. May be you will read before posting something?...

Original comment by Wladisla...@gmail.com on 21 Oct 2010 at 11:19

GoogleCodeExporter commented 8 years ago 
Don't worry dingochavezz, Wow's LUA interpreter is in a sandbox meaning it LUA 
code run in wow CAN'T harm your computer. 

Anyway, The issue is that EPGP's LibGuildStorage needs to see offline in order 
to function properly.  That's why they've disabled the "Show offline members" 
checkbox (yes, it's intentional.  See the ForceShowOffline() function mentioned 
above).  

My patch hooks ToggleGuildFrame(). The first time it's opened after you load 
wow it creates OnShow and OnHide handlers for the GuildFrame. these handlers 
unlock and uncheck the checkbox when you open the Guild Frame and revert the 
changes when it's closed.

Satisfied?

Original comment by mbuca...@gmail.com on 21 Oct 2010 at 1:10

GoogleCodeExporter commented 8 years ago 
@evlogimenos, I wasn't able to find which functions wouldn't work when not 
showing offline members.  But if you just add the following sniplet before said 
functions  along with some variation of my patch it should work perfectly.

--add before function that needs to see offline members
if GuildFrame then
  GuildFrame:Hide()
end

Original comment by mbuca...@gmail.com on 21 Oct 2010 at 1:30

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
<WoW Game Folder>\Interface\AddOns\epgp

The epgp.lua and LibGuildStorage-1.0.lua are in this folder

Original comment by mbuca...@gmail.com on 22 Oct 2010 at 8:00

GoogleCodeExporter commented 8 years ago 
I'm not sure if you've looked into this. If you change line 256 in 
LibGuildStorage-1.0.lua from:

  local num_guild_members = GetNumGuildMembers()

to:

  local num_guild_members = GetNumGuildMembers(true)

the addon will scan all offline members without requiring "show offline 
members" to be perma-checked. The boolean passed to GetNumGuildMembers will 
allow or disallow scanning of offline members. Then you just need to clean up 
the ForceShowOffline function and its two calls. So far it seems to work well.

Source: http://www.wowwiki.com/API_GetNumGuildMembers

Original comment by bluespri...@hotmail.com on 23 Oct 2010 at 3:43

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Plz fix.. this bug fucks up..

Original comment by myse...@googlemail.com on 23 Oct 2010 at 4:01

GoogleCodeExporter commented 8 years ago 
@mbucari1 - Yes, I know you can't do any damage, just wanted to know what the 
patch actually does. If it simply turns the show offline members off and that 
then means EPGP can't update the officers notes (which is why Alkis turned it 
on permanently), then your patch is not helpful.

@ignac.ru - No comment.

Original comment by dingochavezz@gmail.com on 23 Oct 2010 at 9:09

GoogleCodeExporter commented 8 years ago 
http://code.google.com/p/epgp/issues/detail?id=632#c16

Original comment by dingochavezz@gmail.com on 23 Oct 2010 at 9:13

GoogleCodeExporter commented 8 years ago 
http://code.google.com/p/epgp/issues/detail?id=632#c16

I would rather have a full guild list show all offline (sorted by Last Online 
to see who is online), than have EPGP not working correctly. A fix is in the 
pipeline, as Alkis has stated.

Original comment by dingochavezz@gmail.com on 23 Oct 2010 at 9:14

GoogleCodeExporter commented 8 years ago 
I have copied and pasted the links listed above to the correct folders and I am 
still having the same issue. Besides that is there something else we are 
supposed to be doing?

Original comment by jdbus...@gmail.com on 24 Oct 2010 at 6:15

GoogleCodeExporter commented 8 years ago 
Yes, wait for Alkis to patch it.

Original comment by dingochavezz@gmail.com on 24 Oct 2010 at 9:01

GoogleCodeExporter commented 8 years ago 
I got it fixed and thanks for the help it just took me a while to get 
everything copied and paste in the correct spot in the folders. I don't know 
anything about code and had a hard time finding the specific locations to paste 
the corrected code. After coping the code to word then back to the notepad it 
made things much easier to locate and make the changes.

Original comment by jdbus...@gmail.com on 24 Oct 2010 at 6:55

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Issue 646 has been merged into this issue.

Original comment by evlogimenos on 27 Oct 2010 at 9:25

GoogleCodeExporter commented 8 years ago 
@blue

I have tested this change, removed the ForceShowOffline calls and function.  It 
seems to work for me.

Looking at the diffs
1399->1402 - Removed multiple calls to GetNumGuildMembers(true) and created a 
local variable to store the number once per Frame_OnUpdate() call.  This would 
definitely optimize the code.

ISSUE: the call to GetNumGuildMembers() does not contain a boolean value for 
true or false like blue said.

FIX: change GetNumGuildMembers() to GetNumGuildMembers(true) and remove all 
changes in r.1407

Original comment by Matt...@gmail.com on 28 Oct 2010 at 5:54

GoogleCodeExporter commented 8 years ago 
Issue 650 has been merged into this issue.

Original comment by evlogimenos on 6 Nov 2010 at 10:22

GoogleCodeExporter commented 8 years ago 
Please fix it! :(
Can't you get the comments/data on login and then disable it and maybe enable 
show all again to get the data (?) when someone awards EP/GP and then disable 
it again?

Original comment by the.bl4c...@gmail.com on 8 Nov 2010 at 4:46

GoogleCodeExporter commented 8 years ago 
There is a new version coming, and it will be fixed then.

Original comment by dingochavezz@gmail.com on 8 Nov 2010 at 5:44

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
i have a work around for this. its not a solution so to say but till it gets 
permanently fixed this is what i am doing. 

ive made 2 macros and put them on a seperate action bar. i use these 2 buttons 
to do all my epgp assignments.
the 1st one is

/epgp
/run SetGuildRosterShowOffline(true);

i use this whenever i want to assign epgp etc and once the raid is over and all 
epgp business is done i use

/epgp
/run SetGuildRosterShowOffline(false);

Original comment by mohd.has...@gmail.com on 10 Nov 2010 at 6:21

GoogleCodeExporter commented 8 years ago 
Bumping this for resolution. Please I need this fixed. My entire guild is tired 
of having to sort by guild status online. Any ETA, are you waiting until after 
Dec 7th to publish a new version or something?

Original comment by cyber...@gmail.com on 1 Dec 2010 at 9:08

GoogleCodeExporter commented 8 years ago 
Work is being done to fix this. You could help by losing the attitude.

Original comment by evlogimenos on 1 Dec 2010 at 10:47

GoogleCodeExporter commented 8 years ago 
Issue 657 has been merged into this issue.

Original comment by evlogimenos on 2 Dec 2010 at 1:26

GoogleCodeExporter commented 8 years ago 
This is fixed in epgp-6.

Relevant change 
http://code.google.com/p/epgp/source/detail?r=2cbf90a611fd3748769eabced9145ff4a0
25212f

Original comment by evlogimenos on 2 Dec 2010 at 11:42

GoogleCodeExporter commented 8 years ago 
Issue 667 has been merged into this issue.

Original comment by evlogimenos on 17 Dec 2010 at 12:54

GoogleCodeExporter commented 8 years ago 
Issue 670 has been merged into this issue.

Original comment by evlogimenos on 21 Dec 2010 at 11:37

GoogleCodeExporter commented 8 years ago 
Issue 671 has been merged into this issue.

Original comment by evlogimenos on 21 Dec 2010 at 11:38

GoogleCodeExporter commented 8 years ago 
About that hack... Won't it cause the addon to fail if any operation is 
performed on the offline members while the guild interface is open and offline 
members are not shown in it?

Original comment by kane...@gmail.com on 23 Dec 2010 at 10:38