cmake refactor off dev - Githubissues

ExCALIBUR-NEPTUNE / NESO-Particles

https://excalibur-neptune.github.io/NESO-Particles/main/sphinx/html/index.html

MIT License

3 stars 2 forks source link

cmake refactor off dev #57

Closed seimtpow closed 7 months ago

seimtpow commented 8 months ago

Rebased on dev
changed the name back
changed the way the tests find sycl to match what NESO does (now - I changed that too)
Remove a "using namespace std" from a header

will-saunders-ukaea commented 8 months ago

This looks like it is branched from dev - so the PR can be into dev not main right?

edit "merged from" -> "branched from"

seimtpow commented 8 months ago

This looks like it is branched from dev - so the PR can be into dev not main right?

edit "merged from" -> "branched from"

Should be correct now. Ta

will-saunders-ukaea commented 7 months ago

I think the way forward now is to: 1) Merge dev into main and make a release with all the changes pre this PR. 2) Merge this into dev (or maybe main). 3) When this PR makes it main make another release for the updated interface.