ExCALIBUR-NEPTUNE / NESO-Spack

Spack repository for installing NESO components and dependencies.

MIT License

2 stars 2 forks source link

added HipSYCL (OpenSYCL?) version 0.9.4 #20

Closed will-saunders-ukaea closed 1 year ago

will-saunders-ukaea commented 1 year ago

Added hipsycl (now opensycl) v0.9.4 and made preferred. A local memory bug with the cuda-nvcxx backend is fixed in hipsycl 0.9.4 and nvhpc 22.9. We use sycl local memory in the upcoming 2D3V evaluation/projection kernels.
Placed a minimum 22.9 version requirement on nvhpc for the nvcxx backend.

Tests

Checked unit/integration tests (on NESO main) passed (omp backend).

cmacmackin commented 1 year ago

Happy to approve this, but one small thing first. You should put the different versions in descending order. In that case you won't need to specify one as preferred either, as the first one listed is preferred by default. Not a new issues obviously, but only just noticed it.

will-saunders-ukaea commented 1 year ago

Thanks - Reordered versions and removed a spurious maintainer line.

cmacmackin commented 1 year ago

OK, all merged. Remember to update the commit the submodule points to in the main NESO repository.