search

ExCALIBUR-NEPTUNE / NESO

MIT License
4 stars 4 forks source link

Update NESO-Particles submodule to the HDF5 fix #219

Closed will-saunders-ukaea closed 11 months ago

will-saunders-ukaea commented 1 year ago

Bumps the NP submodule to the commit which contains the enable c cmake fix for hdf5. Looks like we need this to build on archer2 using the provided hdf5 installs (building hdf5 fails for other reasons).

Also includes the ParticleLoop.

will-saunders-ukaea commented 1 year ago

Seems this creates new issues building NP on archer2....

will-saunders-ukaea commented 1 year ago

With the second update this builds for me on archer2.

will-saunders-ukaea commented 1 year ago

Waiting on https://github.com/ExCALIBUR-NEPTUNE/NESO-Particles/pull/38 Edit: also need to rework the std::variant in NP - it's causing issues with nvc++ in NESO. Edit: waiting on: https://github.com/ExCALIBUR-NEPTUNE/NESO-Particles/pull/51

will-saunders-ukaea commented 11 months ago

Tests pass for me with acpp (cuda + omp) (modulo the 1D ones expected to fail) and dpcpp.