ExCALIBUR-NEPTUNE / NESO

MIT License
4 stars 4 forks source link

Added template argument to interpolator #234

Closed JamesEdgeley closed 4 months ago

JamesEdgeley commented 5 months ago

Description

Newest versions (>=5.3) of Nektar++ have FieldUtils::Interpolator as a template class - this PR adds the argument

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Testing

Please describe the tests that you ran to verify your changes and provide instructions for reproducibility. Please also list any relevant details for your test configuration.

Test Configuration:

Checklist:

oparry-ukaea commented 5 months ago

Hi @JamesEdgeley, I'm updating NESO to use a recent nektar version in #232 and have made a similar change to this one. Is this holding you up? If not, it might be easier to wait for me to merge that (hopefully later on this week)

JamesEdgeley commented 5 months ago

Not a problem, I've implemented it locally anyway. Does your change break support for the older nektar versions?

oparry-ukaea commented 5 months ago

Don't remember, to be honest... Since each NESO commit is locked to a particular nektar commit via the nektar submodule anyway, we (I) haven't really made an effort to make the nektar calls backwards compatible...

oparry-ukaea commented 4 months ago

Hi @JamesEdgeley - I included your version of this change in #240, so will close this now.