search

ExCiteS / geokey

Platform for participatory mapping
http://geokey.org.uk
Other
55 stars 29 forks source link

Django 1.9 #336

Closed ghost closed 8 years ago

ghost commented 8 years ago

Tests are set up and code is improved to be able to run on Django 1.9. However, we will still require Django 1.8 by default with a possibility to manually update it to 1.9.

This closes https://github.com/ExCiteS/geokey/issues/332.

mstevens83 commented 8 years ago

Nice work. Perhaps it is also best to now also put Django>=1.8.8 instead of Django==1.8.8 in requirements.txt.

ghost commented 8 years ago

Can't do that. This says to install anything what's bigger than this, and currently it's 1.9.2.

When installing with a command line, this can be used to install the latest 1.8:

pip install django'>=1.8,<1.9'

However, this condition cannot be used with setuptools.

Any clever alternatives are welcome.

mstevens83 commented 8 years ago

Are you sure? Doesn't Django>=1.8.8 mean "use or install any version of Django equal than or highert than 1.8.8"? Meaning that if a user already has 1.9.x it will use it, but if he has 1.8.8 or 1.8.9, etc. it won't upgrade to 1.9.x.

ghost commented 8 years ago

I tried to uninstall Django completely and then it installed 1.9.2 with this condition.

mstevens83 commented 8 years ago

Yes that's expected. If nothing's there is installs the latest. But that's OK right? I mean you made sure gk works on 1.9.

ghost commented 8 years ago

We still going to use 1.8, 1.9 is only possibility. And I will be developing in regards to support both for now.