search

ExCiteS / geokey

Platform for participatory mapping
http://geokey.org.uk
Other
55 stars 29 forks source link

Wrongly written function - unexpected output when running tests #413

Open josokinas opened 6 years ago

josokinas commented 6 years ago

Function within contribution utils get_authenticated_service has a bad try except written, where error is just printed out instead of throwing something.

When running tests I see the output:

screenshot 2018-10-21 at 18 12 26
JamesBradbury commented 6 years ago

These tests have no useful assertions in them anyway, so I'm going to remove them.

JamesBradbury commented 6 years ago

That and the bogus try-catch will be corrected as part of the py3_upgrade branch.

josokinas commented 6 years ago

Great - I would suggest thought not removing the test but improving so that it makes sense... I've noticed GeoKey test coverage dropped in the past year... There was 95 or even 97% previously.