search

ExHammer / hammer-backend-redis

A Redis backend for for the Hammer rate-limiter
https://hexdocs.pm/ExHammer/hammer-backend-redis
MIT License
50 stars 32 forks source link

Adapt to new Hammer API #56

Open ruslandoga opened 1 year ago

ruslandoga commented 1 year ago

This PR conforms to the new api introduced in https://github.com/ExHammer/hammer/pull/104 and also improves performance somewhat by removing unnecessary GenServer processes and poolboy

epinault commented 2 weeks ago

fine for an RC. for final I do want typespec. I have spent time adding them in the past to help documenting and dialyzer be more correct

ruslandoga commented 2 weeks ago

The functions here are @callback implementations that already have typespecs.

epinault commented 2 weeks ago

what s the plan here? merge in master or are we gonna first release Hammer then update this to proper version and update? this is still pointing to a branch

ruslandoga commented 2 weeks ago

The Hammer PR needs to be merged first. Then the backends. I described the plan in the Hammer PR.