Investigate Bottlenecks

ExHammer / hammer

An Elixir rate-limiter with pluggable backends

https://hexdocs.pm/hammer/

MIT License

749 stars 42 forks source link

Investigate Bottlenecks #19

Closed JuneKelly closed 6 years ago

JuneKelly commented 6 years ago

I've got this weird feeling that we may be introducing a bottleneck by passing all rate-checks through one backend process. Performance seems pretty good in my tests, but I'd rather not be dragging down the throughput of applications unnecessarily.

Actions:

[ ] investigate worker-pool options
[ ] experiment with making the backends a worker pool
[ ] decide what to do

JuneKelly commented 6 years ago

@sobolevn any thoughts on this?

sobolevn commented 6 years ago

Maybe we should start with the benchmark tests and profiling? So we will know what and how needs to be optimized.

JuneKelly commented 6 years ago

This is addressed in version 4.0.0, just released.

sobolevn commented 6 years ago

@ShaneKilkelly awesome! 🎉