ExHammer / hammer

An Elixir rate-limiter with pluggable backends
https://hexdocs.pm/hammer/
MIT License
749 stars 42 forks source link

Remove unused os variable from the matrix #76

Closed sato11 closed 10 months ago

sato11 commented 10 months ago

The top-level runs-on value has been pinned to ubuntu-latest and this os variable has no place to live when running tests, resulting in only doubling the workload for no benefits.

Although we can actually start to test on the both os versions, this commit does not go for it and chooses to use ubuntu-latest solely.

This is because it is hard to imagine that the os version affects the outcome as long as the versions of otp and elixir are set, and this is what the popular libraries like plug and phoenix use as their strategy^1.

epinault commented 10 months ago

Close as fixed with #81