Primo VE and addons - Githubissues

uleodolter commented 5 years ago

It seems there is an issue with Primo VE and addons.

I tried the following Primo VE and Altmetrics addon. https://uah.primo.exlibrisgroup.com/discovery/search?vid=01UAH_INST:01UAH_V1&lang=en&sortby=rank

The resulting js/custom.js starts with following lines

(function(){
"use strict";
'use strict';

//Auto generated code by primo app store DO NOT DELETE!!! -START-
/*
    hookName is a place holder with should hold the hook name not including "prm" at the beginning and in upper camel case
    e.g: for hook prmSearchBarAfter (in html prm-search-bar-after) it should be given "SearchBarAfter"
 */
app.controller('FullViewAfterController', [function () {
    var vm = this;
}]);

As you can see app is not defined, it seems that custom.module.js is missing when using Primo VE. This is different to non Primo VE, where i can see readonly js/custom.module.js in editor which creates the app variable.

Please check

gilax commented 5 years ago

@uleodolter. can you please check that your issue is really fixed?

uleodolter commented 5 years ago

@gilax yes it works now, thx

ExLibrisGroup / Primo-Studio

Primo VE and addons #7