chore(update npm/node): Update recommended software versions and dependencies - Githubissues

ExLibrisGroup / primo-explore-devenv

A node.js , gulp based development enviornment for Primo's new UI customizations (css,images,html and javascript)

BSD 3-Clause "New" or "Revised" License

114 stars 84 forks source link

chore(update npm/node): Update recommended software versions and dependencies #105

Closed atla5 closed 4 years ago

atla5 commented 5 years ago

Background

the versions of node and npm specified in the README (#12) are v6.9.2 and 3.3.12 respectively
the @latest versions of those are v12.4.0 and 6.9.2, respectively (!!), and neither are being supported anymore
an npm audit turns up 74 vulnerabilities, 60 of which can likely be solved by running npm audit fix
it looks like PR #103 addresses these concerns

Desired Changes

ensure that the devenv works on at least node version 10.16.0 (LTS EOL 2021) and npm version 6.X (npm LTS policy)
run $npm audit fix and run tests to ensure there aren't any regressions
update the README to reference the (earliest and) most recent versions of npm and node the devenv supports

atla5 commented 5 years ago

note, related: #103 #12

etgrieco commented 5 years ago

@atla5 Thank you!

NoamaExl commented 4 years ago

closing as PR are merged