ExMod-Team / EXILED

A high-level plugin framework for SCP: Secret Laboratory servers (scpsl). It offers an event system for developers to hook in order to manipulate or change game code, or implement their own functions.
https://docs.exiled-team.net/
Other
55 stars 36 forks source link

`[EXILED::API]` Adding ScaleNetworkIdentityObject #49

Closed NotZer0Two closed 2 months ago

NotZer0Two commented 2 months ago

Description

Describe the changes Let's you scale down or up everything that has an NetworkIdentity

SPOILER_immagine immagine

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

Submission checklist

Patches (if there are any changes related to Harmony patches)

Other

VALERA771 commented 2 months ago

I think you can use NetworkServer.Unspawn and NetworkServer.Spawn for cases when you need to move object for all players. And isn't it a duplicate from your previous pr? (code is similar as I can see)

NotZer0Two commented 2 months ago

I think you can use NetworkServer.Unspawn and NetworkServer.Spawn for cases when you need to move object for all players. And isn't it a duplicate from your previous pr? (code is similar as I can see)

yes it is, in future i will probably do one method for everything but currently i want to them seperated when the update will be released i will do it

VALERA771 commented 2 months ago

And is there any difference between this pr and #48?

NotZer0Two commented 2 months ago

And is there any difference between this pr and #48?

Yes localscale its the only differents

VALERA771 commented 2 months ago

There is local position. Seems that you haven't edited it

NotZer0Two commented 2 months ago

Im stupid and forgot to change the name

VALERA771 commented 2 months ago

I'm about that you're still setting localPosition in method

Misaka-ZeroTwo commented 2 months ago

pls fix build errors