ExMod-Team / EXILED

A high-level plugin framework for SCP: Secret Laboratory servers (scpsl). It offers an event system for developers to hook in order to manipulate or change game code, or implement their own functions.
https://docs.exiled-team.net/
Other
55 stars 36 forks source link

`Scp330` sound fix #55

Closed IRacle1 closed 2 months ago

IRacle1 commented 2 months ago

Description

Describe the changes I barely understand what exactly second part of 330interaction transpiler does, but still rewrote it as I found it simpler

What is the current behavior? (You can also link to an open issue here) Surely sever logic is fine, but affects the sound rpc

What is the new behavior? (if this is a feature change) Make ev.Sever work without breaking rpc

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no

Other information: @louis1706 @Undid-Iridium im not sure i did that correctly, thats what my patch do:

image


Types of changes

Submission checklist

Patches (if there are any changes related to Harmony patches)

Other

ITeMbI4 commented 2 months ago

Fancy console background =)

louis1706 commented 2 months ago

If you have time could you add a property to chooses whetever or not than sound is made ?

IRacle1 commented 2 months ago

If you have time could you add a property to chooses whetever or not than sound is made ?

yeah sure