ExMod-Team / EXILED

A high-level plugin framework for SCP: Secret Laboratory servers (scpsl). It offers an event system for developers to hook in order to manipulate or change game code, or implement their own functions.
https://exmod-team.github.io/EXILED/
Other
38 stars 21 forks source link

Scp0492 change apperance fix #87

Closed Undid-Iridium closed 5 days ago

Undid-Iridium commented 2 weeks ago

Description

Describe the changes https://discord.com/channels/656673194693885975/1276117397685665885/1276117397685665885 tl;dr - 0492 change appearance breaks clients before change.

longer: changing appearance to 0492 causes clients to disconnect due to missing serialization data. When deserializing, there is a base call to a shared base deserialization function for humanoid types.

What is the current behavior? (You can also link to an open issue here) Clients crash when 0492 is used in ChangeAppearance

What is the new behavior? (if this is a feature change) Doesn't crash

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No

Other information:


Types of changes

Submission checklist

Patches (if there are any changes related to Harmony patches)

Other

https://github.com/user-attachments/assets/75e3dd31-7666-4556-ae3b-069d760882b9