ExOptsTeam / NFSCExOpts

Need for Speed Carbon Extra Options
GNU General Public License v3.0
78 stars 12 forks source link

UnlockAllThings REALLY should be disabled by default, not auto-unlock. #52

Open jaigitrep159 opened 3 weeks ago

jaigitrep159 commented 3 weeks ago

after launching the game, it seems like it auto-unlocks all things... until i realized this line here: https://github.com/ExOptsTeam/NFSCExOpts/blob/36e383915d1dcab60dcca6b4587f145bf9bdfc27/NFSCExtraOptions/dllmain.cpp#L315C2-L315C81

it REALLY should be disabled by default and not auto-unlock everything everytime i launch the game.

This is 1.4 Collectors Edition patch btw. please fix

jaigitrep159 commented 3 weeks ago

seems like there's a compatibility mode issue...? I set to Windows XP SP3 and this happened here, i think... this is really odd tbh

jaigitrep159 commented 3 weeks ago

Yep, as i found out,

in Line 315:

UnlockAllThings = iniReader.ReadInteger("Gameplay", "UnlockAllThings", 0) == 1;

is a bug.

should be:

UnlockAllThings = iniReader.ReadInteger("Gameplay", "UnlockAllThings", 0) != 0;

referencing here: https://github.com/ExOptsTeam/NFSMWExOpts/blob/8a094fe29d28195bdcf69122dbfe945f16315f9a/NFSMWExtraOptions/ExtraOptionsStuff.h#L105