ExPaNDS-eu / ExPaNDS-experimental-techniques-ontology

EU Photon and Neutron Ontologies (task 3.2)
8 stars 4 forks source link

Fixes bugs (spectroscopy, inelastic SAS), adds disjoints, no inferred… #114

Closed spc93 closed 5 months ago

spc93 commented 5 months ago

… axioms.

Motivation: Small change that fixes some errors and enables disjoint class relationship (which in turn helps to identify logical inconsistencies, such as a technique being simultaneously elastic and inelastic. The issues addressed are outlined in Milestone-1 and documented below.

........................................

change the label from 'photoemission microscopy' to 'photoemission electron microscopy' (as the preferred name) add 'PEEM' (already included) and 'photoelectron emission microscopy' as alternative names

Also needed to: change two references to 'photoemission microscopy' to be 'photoemission electron microscopy' change 'x-ray photoemission microscopy' to 'x-ray photoemission electron microscopy'

Closes: #54 ........................................

The name for term PaNET01107 reads inelastic small angle scatteringng. I suspect this is a typo.

Label changed to 'inelastic small angle scattering'

Closes: #76 ........................................

        delete equivalent class 'versus energy'
        replace subclass (of) 'defined by functional dependence' with subclass 'versus energy'
        Note: This changes the definition of PaNET01165 (MAD) so it is no longer a spectroscopy
        Note: subclass of 'defined by functional dependence' is no longer required as 'versus energy' is already a subclass of 'defined by functional dependence'

Closes: #53

...........................................

Error in PaNET01107 (inelastic small angle scattering)

Change made: 'small angle scattering' (PaNET01124) should be a subclass of 'low momentum transfer scattering' but not 'diffraction'

Closes: #104

...........................................

Achieved by adding a 'DC %' column in the csv file (new column Q in csv spreadsheet).

Closes #105 ...........................................

Change to definition of PaNET01034 ('inelastic scattering') to be disjoint with PaNET01020 ('elastic scattering')

Closes #106 ...........................................