Added thiserror dependency and changed the error type to use it

ExPixel / miniaudio-rs

Rust bindings for miniaudio C library.

https://crates.io/crates/miniaudio

MIT License

49 stars 20 forks source link

Added thiserror dependency and changed the error type to use it #50

Closed ohmree closed 3 years ago

ohmree commented 3 years ago

Following up on #49, I made a few quick changes to miniaudio::Error to make it use thiserror and removed some now-redundant code.

Is this okay? I could refactor it into a manually implemented version without thiserror if the extra dependency is a no-no, I only used it because it's what I know and I like how the message is coupled with the error.

ExPixel commented 3 years ago

Thank you for the PR! 😃 I would like to avoid extra dependencies in the library if possible. I use thiserror myself and might make use it if this library starts generating more complex errors but for now I think a match would suffice.