search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.06k stars 441 forks source link

Refactor how config originated routes are deleted from outgoing RIB t… #1127

Closed longmalx closed 1 year ago

longmalx commented 1 year ago

Previous the old routes from the configuration were deleted from the peer reactor, leading to the RIB become out of date if the neighbor was offline when an update or sequence of updates was made.

Refactored to this so that any deleted configuration routes are removed from RIB during configuration reload rather than from the reactor.

Tested this with a variety of normal and FlowSpec routes and the RIB is correct all configuration reloads.

longmalx commented 1 year ago

I've noticed that just updating the next hop or community doesn't seem to be handled correctly - will investigate.

thomas-mangin commented 1 year ago

Thank you very much, Malcolm. Are all the tests still passing? in particular, the encoding tests in ./qa/bin/functional? If so, I will merge.

thomas-mangin commented 1 year ago

Just noticed your comment about next-hop. Thank you for the thorough checking.

longmalx commented 1 year ago

I have a fixed up patch which is working correctly with my manual testing - I will try the functional tests.