search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.06k stars 441 forks source link

Refactor how config routes are deleted from outgoing RIB to handle offline routers #1128

Closed longmalx closed 1 year ago

longmalx commented 1 year ago

This resolves issue #1126.

Previously the old routes from the configuration were deleted from the peer reactor, leading to the RIB become out of date if the neighbor was offline when an update or sequence of updates was made.

Refactored to this so that any deleted configuration routes are removed from RIB during configuration reload rather than from the reactor.

Tested this with a variety of normal and FlowSpec routes and the RIB is correct all configuration reloads. I have run all the QA functional tests successfully.

thomas-mangin commented 1 year ago

I have merged the patch but now wonder if there will be an issue with API routes? I need to check.