search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.08k stars 445 forks source link

mup: add Source Address to Type 1 ST Route #1193

Closed takehaya closed 8 months ago

takehaya commented 9 months ago

This patch adds Source Address to Type 1 ST Route as defined in draft-mpmz-bess-mup-safi-03. See https://datatracker.ietf.org/doc/html/draft-mpmz-bess-mup-safi-03#section-3.1.3

thomas-mangin commented 9 months ago

Very nice. Could I please ask for a separate test rather than extending the current one.

thomas-mangin commented 9 months ago

Thank you for your work, if you can please update the PR with the suggested changes, I will then happily merge.

takehaya commented 9 months ago

@thomas-mangin san Thank you for your kind review!

Very nice. Could I please ask for a separate test rather than extending the current one.

What tests does this expect to add?I would like to know if you would like 🙏

thomas-mangin commented 9 months ago

You are welcome.

The test you wrote is good but it is using an existing file. If you create a new configuration and test files instead, it keeps the new test separate.

The configuration file needs to be created in etc/exabgp and a .ci and .msg file created in qa/encoding. qa/bin/functional can be used to run the new test.

takehaya commented 9 months ago

thanks comment :) i try fixed that because your kind feedback. pls continue review 🙏

takehaya commented 8 months ago

@thomas-mangin -san thanks for your review! 🙏