thomas-mangin
commented
1 month ago I have added some test for this use case on master - not checked 4.2:
❯ ./qa/bin/functional encoding --list
The available tests are:
0 api-add-remove 1 api-announce-processes-match 2 api-announce-star
3 api-announce 4 api-announcement 5 api-api
6 api-attributes-path 7 api-attributes-vpn 8 api-attributes
9 api-broken-flow A api-check B api-eor
C api-fast D api-flow-merge E api-flow
F api-ipv4 G api-ipv6 H api-manual-eor
I api-multi-neighbor J api-multiple-api K api-multisession
L api-nexthop-self M api-nexthop N api-no-respawn
O api-notification P api-open Q api-reload
R api-rib S api-rr-rib T api-teardown
U api-vpls V api-vpnv4 W conf-addpath
X conf-aggregator Y conf-attributes Z conf-ebgp
a conf-extended-attributes b conf-flow-redirect c conf-flow
d conf-generic-attribute e conf-group-limit f conf-group
g conf-ipself4 h conf-ipself6 i conf-ipv46routes4family
j conf-ipv46routes6family k conf-ipv6grouping l conf-l2vpn
m conf-largecommunity n conf-name o conf-new-v4
p conf-new-v6 q conf-no-asn4 r conf-parity
s conf-path-information t conf-prefix-sid u conf-split
v conf-srv6-mup-v3 w conf-srv6-mup x conf-template
y conf-unknowncap z conf-vpn α conf-watchdog ❯ ./qa/bin/functional encoding --dry D
> ./qa/bin/functional encoding --server D --port 1803
> ./qa/bin/functional encoding --client D --port 1803It is passing:
❯ ./qa/bin/functional encoding D
✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✓ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖You can look at files with
./qa/bin/functional encoding --edit DThe API is using: announce flow route { match { source 2.2.2.2/32; } scope { interface-set [ non-transitive:input:3405770241:1 transitive:output:254:254 ]; } then { discard; } }
which is translated to FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF:004F:02:000000384001010040020040050400000064C010184702CAFFEE0140010702000000FE80FE8006000000000000800E0C000185000006022002020202 (raw:5:)
This is decoded as:
❯ ./sbin/exabgp decode 000000384001010040020040050400000064C010184702CAFFEE0140010702000000FE80FE8006000000000000800E0C000185000006022002020202 | jq
{
"exabgp": "5.0.0",
"time": 1717888731.297666,
"host": "MacBook-Pro-3.local",
"pid": 63926,
"ppid": 81437,
"counter": 1,
"type": "update",
"neighbor": {
"address": {
"local": "127.0.0.1",
"peer": "127.0.0.1"
},
"asn": {
"local": 65533,
"peer": 65533
},
"direction": "in",
"message": {
"update": {
"attribute": {
"origin": "igp",
"local-preference": 100,
"extended-community": [
{
"value": 5116875327204835329,
"string": "interface-set:input:3405770241:1"
},
{
"value": 504966108235596030,
"string": "interface-set:output:254:254"
},
{
"value": 9225060886715039744,
"string": "rate-limit:0"
}
]
},
"announce": {
"ipv4 flow": {
"no-nexthop": [
{
"source-ipv4": [
"2.2.2.2/32"
],
"string": "flow source-ipv4 2.2.2.2/32"
}
]
}
}
}
}
}
}As there is no such thing as an HTTP/HTTPS gateway to ExaBGP, please see with the author of that code if either
- the bug is in the code you use
- the bug is in 4.2, and it would be better to use master
I may backport the test to 4.2.
cwlumen
Describe the bug
When using an API call to announce a new route it appears the interface-set and the discard feature are mutually exclusive when sending updates to the process routes function. The command is accepted as valid but the route is send to the peer with both communities
A curl to my API with the new announcement in it
I can see the announcement is accepted, and has both options, but when it gets announced to the peer ( the API line and actual payload) it will only have the interface-set extended community.
Everything works correctly when a peer is configured with both options in the config file. This announcement will have both the interface-set and the discard (rate limit) communities and send both to the router
Order seems to be matter. If the discard keyword comes before interface-set, only the rate-limit community is sent.
To Reproduce
Announce a new flow with both the discard and the interface-set arguments at the same time. Whichever one is first will be sent.
Expected behavior
When making updates, both the interface-set and discard extended communities should be sent. The behavior is correct when a route is defined in the exabgp config file.