search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.07k stars 443 forks source link

Test if capability message is received as expected #1222

Closed ton31337 closed 1 month ago

thomas-mangin commented 2 months ago

can I please ask you to reformat the function in another PR so I can see what changed please?

thomas-mangin commented 2 months ago

As the bgp program is changed, bgp-3.6 will also be updated to match the changes. Otherwise, I will have no chance to make Python 3.6 build stable. ATM, they fail once in a while, but I do not know why (and I need to build an old Ubuntu to debug), so I have left it for later.

thomas-mangin commented 2 months ago

Forget my comment about formatting ..

ton31337 commented 2 months ago

I can drop that reformatting commit for sure, should I drop it or leave it as it is now?

thomas-mangin commented 2 months ago

Leave, it - I am just trying to understand why your code works :-) Just need the same patch to ibgp-3.6

ton31337 commented 2 months ago

Will do in a minute ;)

thomas-mangin commented 2 months ago

ok, it does not allow to test for an OPEN and then an UPDATE - that's ok, it can be added later. It does not break anything.

ton31337 commented 2 months ago

Gh, don't have 3.6 right now...