search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.09k stars 447 forks source link

dyanmic process commands need to be full paths #174

Closed JustinAzoff closed 9 years ago

JustinAzoff commented 10 years ago

Because of the stat checks that exabgp does on run commands you need to put the full path to the tool in the configuration file.

Is there any reason this shouldn't be changed to search PATH?

I can submit a pull request for this but I wanted to see if it was like that for a reason.

thomas-mangin commented 10 years ago

I would rather the path to be explicit for security reason (running a process which is not the expected one) .. I will check the code to make sure it is well behaving as expected .. If you were to submit a patch, I would include it but would like an option to be able to disable the behaviour ( which would be good for the "etc" trick we are doing as well and should be disabled under the same option ) ...

JustinAzoff commented 9 years ago

In the end this was not much of a problem. I'm deploying the exabgp configuration using ansible, so it was not a big deal to have it push out the full path.

thomas-mangin commented 9 years ago

rewritten the 'etc' search.