search

Exa-Networks / exabgp

The BGP swiss army knife of networking
Other
2.05k stars 440 forks source link

Manpages are outdated #938

Open jsenecal opened 4 years ago

jsenecal commented 4 years ago
Summary

ExaBGP manpage needs to reflect the proper (current) parameters.

For instance, --folder is no longer a supported parameter.

Thanks,

OS
Linux E7470-JS 5.3.13-arch1-1 #1 SMP PREEMPT Sun, 24 Nov 2019 10:15:50 +0000 x86_64 Linux
Version
ExaBGP : 4.1.2-d006a34a
Python : 3.7.4 (default, Aug 21 2019, 00:19:59)  [GCC 8.3.0]
Uname  : Linux E7470-JS 5.3.13-arch1-1 #1 SMP PREEMPT Sun, 24 Nov 2019 10:15:50 +0000 x86_64
Root   : /usr/local
Installation

Installing from pip, but the versions available in Debian testing/unstable are the same

pip install --upgrade exabgp==4.1.2
Environment
[exabgp.daemon]
drop = false
Program output
# /usr/local/bin/exabgp --env /etc/exabgp/exabgp.env --folder /etc/exabgp/
usage: exabgp [--help] [--version]
              [--root ROOT] [--env ENV]
              [[--full-ini | --diff-ini | --full-env | --diff-env] |
              [--fi | --di | --fe | --de]]
              [--debug] [--pdb] [--test]
              [--once] [--signal TIME]
              [--memory] [--profile PROFILE]
              [--validate]
              [--run HELPER]
              [--decode HEX_MESSAGE]...
              [<configuration>...]
Importance

Documentation issue (manpage)

thomas-mangin commented 4 years ago

Thank you for reporting the issue. As I did not write the initial man page, any help would be appreciated.

jkldgoefgkljefogeg commented 2 years ago

is -e deprecated? env file path seems to ignore -e https://github.com/Exa-Networks/exabgp/blob/master/src/exabgp/environment/base.py#L4,L8

thomas-mangin commented 2 years ago

Correct on master, to be version 5, the env file is taken from the configuration folder.