search

ExaScience / smurff

Bayesian Factorization with Side Information in C++ with Python wrapper
MIT License
70 stars 14 forks source link

PredictSessions give error with > 2 modes #126

Closed suchow closed 4 years ago

suchow commented 4 years ago

PredictSession's __init__ method asserts that the number of modes is 2. Does this imply that these sessions cannot be used for tensor factorization?

https://github.com/ExaScience/smurff/blob/2bb64fc443abf895e593710ef5d91a9864189583/python/smurff/smurff/predict.py#L175

tvandera commented 4 years ago

Indeed, that is a know limitation, that can easily be fixed. I'll adapt the code.

tvandera commented 4 years ago

Adapted the code, seems to work. All test pass. I'll make a release after some further testing.

tvandera commented 4 years ago

SMURFF v0.16.0 released. Conda and pip packages available.