Unused command line arguments

ExaScience / smurff

Bayesian Factorization with Side Information in C++ with Python wrapper

MIT License

70 stars 14 forks source link

Unused command line arguments #64

Closed motoharu-yano closed 6 years ago

motoharu-yano commented 6 years ago

We have these arguments. They are not parsed. Do we need them? {"row-model", FNAME_ROW_MODEL , "FILE", 0, "initialization matrix for row model"}, {"col-model", FNAME_COL_MODEL , "FILE", 0, "initialization matrix for col model"},

tvandera commented 6 years ago

If they're not used, that seems like a bug

ipasechnikov commented 6 years ago

We have skimmed though cmd_session.cpp file history and it seems that these options have never been implemented. First time they were introduced here 9ad5a2521e0fbe62bd6ed697780b39f2bcae7ce0.

tvandera commented 6 years ago

Indeed. Probably superseded by --restore-suffix

tvandera commented 6 years ago

To be removed.