ExaScience / smurff

Bayesian Factorization with Side Information in C++ with Python wrapper
MIT License
70 stars 14 forks source link

remove argp dependency #67

Closed motoharu-yano closed 6 years ago

motoharu-yano commented 6 years ago

We now have an implementation of command line parser using boost in win-build branch. This implementation is also applicable on linux and it is very straight forward to use on linux. After last discussion we decided to eliminate comman line parser that uses argp and use cross-platform boost implementation.

motoharu-yano commented 6 years ago

I have removed argp dependency in win-build branch. However there are still some linking issues we need to discuss. This is related to boost and python. One solution would be to move CmdSession class to smurff cmake target.

motoharu-yano commented 6 years ago

It was decided to exclude CmdSession from SmurffCpp library cmake file and include it in executables. This should allow to resolve issue with boost linking. Boost should not be required to use python interface.

motoharu-yano commented 6 years ago

done