ExaScience / smurff

Bayesian Factorization with Side Information in C++ with Python wrapper
MIT License
70 stars 14 forks source link

Restore model functionality does not work #77

Closed golipe closed 6 years ago

golipe commented 6 years ago

-- Restoring model, predictions,... from 'demo*.csv'. terminate called after throwing an instance of 'std::runtime_error' what(): [ERROR] File 'demo-U0-latents.csv' not found.

The file is not found because it should be all the files of the form: demo-sample-*-U0-latents.csv and not 'demo-U0-latents.csv'

tvandera commented 6 years ago

todo: document how this option works and how to use it with predict.py script.

tvandera commented 6 years ago

todo: all restore predictions.csv

motoharu-yano commented 6 years ago

Restore functionality should now work as expected. Multiple major changes had happened.

Now it should be possible to stop and continue at any point. If user stops during burnin phase - next time the --root argument is passed - last burnin iteration is restored and burnin continues. If user stops during sampling phase - next time the --root argument is passed - last sampling iteration is restored and sampling continues.

motoharu-yano commented 6 years ago

Latest commits include the following improvement. When previous burning iteration state is removed additional comment line gets added to root file.

motoharu-yano commented 6 years ago

I think this issue can be considered as done. Additional things are addressed in separate issue: https://github.com/ExaScience/smurff/issues/91