modeling test with real side information

ExaScience / smurff

Bayesian Factorization with Side Information in C++ with Python wrapper

MIT License

70 stars 14 forks source link

modeling test with real side information #79

Closed chupvl closed 6 years ago

chupvl commented 6 years ago

We are missing the test for MACAU modeling with side information based on the real data. Proposal to have it ASAP. MoveLens dataset does not contain side information as I know it.

tvandera commented 6 years ago

We have these:

https://github.com/ExaScience/smurff/blob/926f4591ec7dc11532d4fd36f3c90f9a31c8fd00/python/test/gen_tests.py#L303

and those:

https://github.com/ExaScience/smurff/blob/926f4591ec7dc11532d4fd36f3c90f9a31c8fd00/python/test/gen_tests.py#L223

Are these enough?