search

ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

move container tests to test directory #110

Closed zekemorton closed 2 years ago

zekemorton commented 2 years ago

This PR seeks to move all container tests to a /tests/ directory within the sdk container. The key benefits for this in our CI is to run all tests from a single SDK container. This will also allows us to run all tests from the deployed SDK container from docker hub.

This was also a great opportunity to address #66 by changing the default command of the integration Dockerfile to bash

zekemorton commented 2 years ago

@jameshcorbett Thanks for the review! I agree some of the changes to the llnl ci don't quite fit in nicely with this PR, so I am happy to remove them if you think thats best? Otherwise it may be good to place to include them since this PR does mostly have to do with CI. I will likely be making more changes to the ci for both llnl and GitHub once I start working on the dashboard.

jameshcorbett commented 2 years ago

NP, I think it's fine to keep the changes in this PR.