Closed andre-merzky closed 2 years ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
This looks great! Just a few discussion points so that we can keep the two pipelines consistent with each other!
It looks like the conda/rockylinux builds are now failing during flux portion of the install process, do we want to remove that combination from the build matrix for now and create a ticket to investigate further?
Hi @zekemorton : I merged the changes from the llnl-ci
branch and things look ok. This should best be reviewed though after llnl-ci
is merged though to reduce the diff footprint.
It looks like the conda/rockylinux builds are now failing during flux portion of the install process, do we want to remove that combination from the build matrix for now and create a ticket to investigate further?
Yes, that might be the best way forward right now.
GH tests are also complaining about the MongoDB credential I added to the script (and rightly so), so I will have to clean that up also.
It looks like the conda/rockylinux builds are now failing during flux portion of the install process, do we want to remove that combination from the build matrix for now and create a ticket to investigate further?
Yes, that might be the best way forward right now.
So what fails is the centos7 / pip / mpich / python-3.7 combination. I would be inclined to disable python-3.7 for now, as would have the smallest impact on the other tests (I think?) - or do you see a way to disable that specific combination?
.
So what fails is the centos7 / pip / mpich / python-3.7 combination. I would be inclined to disable python-3.7 for now, as would have the smallest impact on the other tests (I think?) - or do you see a way to disable that specific combination?
@wilke, @mtitov : never mind that part - the test which previously failed seems to work now ¯\_(ツ)_/¯
I seem to remember that we wanted to disable that rockylinux8 configuration because of the Flux build failure - so merging this anyway...
Note that this PR is based off @zekemorton 's work in the llnl-ci branch and the diff will only be meaningful once that is merged. I'll also squash the commits once that has happened.