search

ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

Mergify: configuration update #35

Closed SteVwonder closed 3 years ago

SteVwonder commented 3 years ago

This change has been made by @SteVwonder from https://mergify.io config editor.

SteVwonder commented 3 years ago

Note: this depends on #26 being merged first

dongahn commented 3 years ago

Ok. Will wait until Issue #26 lands.

dongahn commented 3 years ago

BTW, great workflow automation and protection!

dongahn commented 3 years ago

From the discussion at Issue #25, this is good to be merged? @SteVwonder ?

SteVwonder commented 3 years ago

Oops. On a second look, it looks like I missed the strict merge option, which ensures that the CI goes green after updating the PR against the base branch (via rebase or merge) before merging into the base branch. Let me add that quickly.

SteVwonder commented 3 years ago

Just rebased onto master. @dongahn, assuming this passes the CI, I believe this PR is ready to go in.

dongahn commented 3 years ago

Sounds good to me. I will add one "approval" which is required in our CI workflow as well.

SteVwonder commented 3 years ago

Thanks! Since this updates the mergify config, someone will need to manually merge this, after which merge-when-passing should be enough.