search

ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

Dockerfiles: Parameterize FROM command, unify Python venv #42

Closed SteVwonder closed 3 years ago

SteVwonder commented 3 years ago

Allow the base image to be set at build time for each dockerfile. This enables the images to be chained/stacked on top of one another. Adjust the CI to leverage this functionality while still testing each component individually. Opens the door to testing pair-wise integrations.

Closes #27

dongahn commented 3 years ago

This has gotten a solid LGTM from @andre-merzky and I will add MWP.

SteVwonder commented 3 years ago

@dongahn or @andre-merzky : this will require a manual merge since it modifies the github workflow yaml file (mergify can't merge those changes)

@mergifyio rebase

mergify[bot] commented 3 years ago

Command rebase: failure

Pull request can't be updated with latest base branch changes GitHub App like Mergify are not allowed to rebase pull request where .github/workflows is changed. This pull request must be rebased manually. err-code: 21B07

dongahn commented 3 years ago

OK. Pulling this in.