expand rp tests - Githubissues

ExaWorks / SDK

ExaWorks SDK

11 stars 12 forks source link

expand rp tests #45

Closed andre-merzky closed 3 years ago

andre-merzky commented 3 years ago

This PR expands the set of tests for RP - they now include a smoke test, unit tests and component tests.

The PR also contains some (commented out) code to run multiple tests in the same GH workflow, and to fail the test if any of them fails.

andre-merzky commented 3 years ago

This PR needs work - RP unit tests should have failed (and did), but GH Actions show success. Will look into it.

SteVwonder commented 3 years ago

Good catch! It looks like github CI's step.run uses fail-fast (e.g., bash -e) so if any of the docker runs fail, that step should fail. It also appears that docker run propagates the exit code of the command up. I wonder if the issue is that the run_rp_test.sh script does not have set -e, so the last line succeeds and the exit code is 0 despite an earlier command failing?

andre-merzky commented 3 years ago

This should be ready for review now.

dongahn commented 3 years ago

@andre-merzky or @SteVwonder: is this ready to go in?

andre-merzky commented 3 years ago

Tests should pass now - if so this would be ready to merge.

SteVwonder commented 3 years ago

Ah. Github workflow was modified so mergify can't merge. Doing so manually.