Closed mtitov closed 3 years ago
@SteVwonder I kept python3-pyyaml
in docker file to have it in sync (link), but you can clean it out with your update
Great! Adding the MWP label.
@SteVwonder @dongahn looks like it is not merged automatically because of this checker status-success="Run test suite"
, but the name for test(s) was changed with added base dockerfile name (centos7
, centos8
)
@mtitov: hmmm... but still the label of the workflow job stays the same as "Run test suite". I wonder if there is an implicit rule within mergefy IO or somewhere in one of our validators which prevent us from automatically merging a PR when it modifies a GitHub action Yaml file.
I propose we wait until @SteVwonder can take a brief look at this and if he concurs with me before manually merging this in.
looks like it is not merged automatically because of this checker status-success="Run test suite", but the name for test(s) was changed with added base dockerfile name (centos7, centos8)
Good catch. The mergify configuration needs to be edited to have more status-success lines, one titled "Run test suite (centos7)" and the other "Run test suite (centos8)" (and the current "Run test suite" check deleted). Once that modification is in, we can double check that Mergify is happy but the PR will need to be manually merged.
@SteVwonder would it be ok to extend this PR for this fix (since CI was edited here)? and now whenever CI is updated need to check if that changes affect mergify
(e.g., adding new base dockerfile)
@SteVwonder would it be ok to extend this PR for this fix (since CI was edited here)?
Yeah, absolutely! Please do.
@mergifyio refresh
Command refresh
: success
Pull request refreshed
Thanks @mtitov . Not sure why Mergify isn't updating its ruleset in this PR, but I used their config validator on this PR and it passes (see image below). So I'll go ahead and merge. Thanks!
Ongoing tests with the corresponding workflow systems