ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

ci: run Flux-Parsl integration tests #63

Closed jameshcorbett closed 2 years ago

jameshcorbett commented 3 years ago

This should probably wait for #51 to go in.

Changes the parsl install from the default pip version to master, and adds an integration dockerfile and test script for testing integrations---not sure if that's the best structure.

jameshcorbett commented 3 years ago

I don't understand why the CI failed so if anyone could explain I would appreciate it 👍

dongahn commented 3 years ago

I don't understand why the CI failed so if anyone could explain I would appreciate it 👍

Looks like something is returning 1.

Screen Shot 2021-08-06 at 1 27 26 PM

dongahn commented 3 years ago

Could be intermittent. Let me restart.

dongahn commented 3 years ago

For GitHub action CI debugging, https://github.com/marketplace/actions/debugging-with-tmate might come in handy.

Probably adding the following step would give you a terminal into the container.

- name: Setup tmate session
      uses: mxschmitt/action-tmate@v3
dongahn commented 3 years ago

This might also be a question for @SteVwonder and @andre-merzky. Are we capturing the logs from the commands running inside our containers in our GitHub action infrastructure? This may come in handy when we need to debug -- beyond being able to say, hey non-zero return from the CMD.

SteVwonder commented 3 years ago

Are we capturing the logs from the commands running inside our containers in our GitHub action infrastructure?

Not sure why the logs aren't popping up in this check. For all of the other CI runs that I've seen, if the docker container (and the processes in it) write to stdout/stderr, then it gets propagated to the GH actions log. I'm tempted to say this is just a weird GH bug/failure for that particular run.

In #51 , I added a flux-specific script that runs to try and summarize any Flux-specific failures that occurred. We could do the same for other components too if we want. We just need to get input from the other components for how to do that for their testsuits.

dongahn commented 3 years ago

@andre-merzky: let us know if you find anything. If you don't, we will just have to wait until @SteVwonder comes back.

dongahn commented 3 years ago

The same here. This PR has been pending for awhile. I would say we discuss to see if we can unstick the current roadblock.

dongahn commented 3 years ago

@jameshcorbett will address Mikhail's comment above. @andre-merzky will look at CI issues above,

jameshcorbett commented 2 years ago

CI passed! I'm now squashing all the incremental commits down to one. The CI should pass again, or I'll lose my mind.

dongahn commented 2 years ago

Wow! heroic @jameshcorbett... you should tell me what the issue was later :-)

jameshcorbett commented 2 years ago

Still a little bit of a mystery what went wrong. The only thing I changed was that I removed the if [singleton tests fail] exit 1; else [run flux-parsl integration] line.

Does someone want to go ahead and merge this?

dongahn commented 2 years ago

Thanks @jameshcorbett !