ExaWorks / SDK

ExaWorks SDK
11 stars 12 forks source link

Added LLNL CI #77

Closed zekemorton closed 2 years ago

zekemorton commented 2 years ago

Added basic CI for LLNL on quartz machine.

Using Git Lab CI, this 3 stage pipeline will build a matrix of base images with parameters for OS (centos7, centos8, ubuntu) and for MPI (openmpi and MPICH). These base images are then written to an image repository, where they are pulled again in stage 2. Stage 2 builds a matrix of core images across all the base images and core packages, and stores them in the remote image repository. Stage 3 pulls all core images and runs their default test scripts.

zekemorton commented 2 years ago

Looks good to me, aside from two typos. Would it be helpful for me to give this a test run on LC? If so, how would I do it?

There are a few different ways you could test it.

1) I have added you as a member of a repo I created in gitlab where you can run the pipeline and see results of the pipeline. This is the repo I used to build and test the CI. 2) You could create your own repo in cz gitlab and test it there. 3) If you wanted to test triggering the pipeline from GitHub and seeing how/if it gets picked up by gitlab, you will have to create a couple of branch on GitHub, then run a merge request from one that is a copy of my branch to one that's a copy of master, and then see the results on this gitlab repo.

I'd also be happy to meet with you sometime to walk you through it!

zekemorton commented 2 years ago

I took a look at the pipelines. It looks like there were some failures in your repo's pipelines:

The failures in the pipeline have to do with the testing script for swift-t when using mpich. We need to add an environment variable to add some logic (as mentioned above) to use different configuration when running with different mpis. I think this is better suited to be resolved In a different MR, but still waiting on consensus there. To me, the failures are a sign of success that we caught a bug that could have otherwise gone unnoticed

Thanks so much for reviewing!